Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated code from jnr-ffi in Ruby ffi backend #6987

Open
headius opened this issue Jan 6, 2022 · 0 comments
Open

Duplicated code from jnr-ffi in Ruby ffi backend #6987

headius opened this issue Jan 6, 2022 · 0 comments
Milestone
JRuby 10.0.0.0

Comments

@headius
Copy link
Member

headius commented Jan 6, 2022

As part of #6985 and #6896 I discovered that among other things VariadicInvoker includes a lot of duplicated code from jnr-ffi. As a result I had to reproduce changes from jnr/jnr-ffi#292 manually in JRuby.

We should endeavor to eliminate as much of this duplication as possible, perhaps with changes to jnr-ffi to expose more utility code that is currently inaccessible (such as the getContext shortcuts that accept a fixed param count).
@headius headius modified the milestones: JRuby 9.3.4.0, JRuby 9.4.0.0 Jan 6, 2022
headius added a commit to headius/jruby that referenced this issue Jan 6, 2022
@headius
Duplicate fixed param count logic from jnr-ffi
bd8463c 
This class was largely copied from jnr-ffi, and duplicates this
logic. Patch brings over the updates for variadic function calls
to support Ruby FFI on M1.

See jruby#6987
@headius headius modified the milestones: JRuby 9.4.0.0, JRuby 9.5.0.0 Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 10.0.0.0
Development

No branches or pull requests
1 participant
@headius