Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New timeout impl leaves dangling threads #7349

Open
headius opened this issue Sep 7, 2022 · 3 comments
Open

New timeout impl leaves dangling threads #7349

headius opened this issue Sep 7, 2022 · 3 comments

Comments

@headius
Copy link
Member

headius commented Sep 7, 2022

This is discussed in detail in ruby/timeout#21. I will be disabling the testTimeoutCleanup test in our ScriptingContainerTest temporarily until we can get a fix merged and released.

@headius headius added this to the JRuby 9.4.0.0 milestone Sep 7, 2022
headius added a commit that referenced this issue Sep 7, 2022
See #7349 and the fix in ruby/timeout#21 which will address it.
@headius headius modified the milestones: JRuby 9.4.0.0, JRuby 9.4.1.0 Nov 10, 2022
@headius
Copy link
Member Author

headius commented Nov 10, 2022

The test is still affected despite #7351 due to differences in how aggressively we shut down threads in an embedded scenario. Previously, we registered a hook that would shut down known timeout threads, as part of embedded teardown.

@justinstoller
Copy link
Contributor

Where is this at?

Before I jump into attempting a local workaround, Is there a patch we take up or a preferred work around similar to puppetlabs/puppetserver@c376084 that we could employ?

@headius
Copy link
Member Author

headius commented Jan 26, 2023

Newer JRuby versions have the fix from #7351, which makes timeout shut down properly under normal circumstances. Embedded JRuby use cases should get the same effect by tearing down the org.jruby.Ruby runtime. This does not fix the issue of the timeout library not providing a way to actively shut down without terminating the entire runtime, but it should prevent most typical users from seeing any issues.

@headius headius modified the milestones: JRuby 9.4.1.0, JRuby 9.5.0.0 Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants