Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby2_keywords should not warn when using ... #7676

Closed
enebo opened this issue Feb 19, 2023 · 1 comment
Closed

ruby2_keywords should not warn when using ... #7676

enebo opened this issue Feb 19, 2023 · 1 comment
Milestone
JRuby 9.4.3.0

Comments

@enebo
Copy link
Member

enebo commented Feb 19, 2023

We warn:

def array(...)
end
ruby2_keywords :array
../snippets/warn6.rb:3: warning: Skipping set of ruby2_keywords flag for array (method accepts keywords or method does not accept argument splat)
@enebo enebo added this to the JRuby 9.4.2.0 milestone Feb 19, 2023
@enebo
Copy link
Member Author

enebo commented Feb 19, 2023

Note: ... decomposes into (*, **, &) and we see the ** and think, "whelp ... we have kwrest better warn".

@enebo enebo modified the milestones: JRuby 9.4.2.0, JRuby 9.4.3.0 Mar 8, 2023
@enebo enebo closed this as completed in 633d2eb Apr 20, 2023
enebo added a commit that referenced this issue Apr 20, 2023
@enebo
Merge pull request #7755 from enebo/forward_warn
ef44025 
Fixes #7676. ruby2_keywords should not warn when using ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.4.3.0
Development

No branches or pull requests
1 participant
@enebo