New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sass-embedded gem extension install fails with rake require error on Windows with JRuby 9.4.2.0 #7717
Comments
Wow this is weird. Investigating. |
I searched for the error a bit and most explanations point to a bad installed gem or bad gem home or something. I'm trying to reproduce on my end; just installing sass-embedded should do it? |
Doesn't seem like I can reproduce on my current system because it is arm64-based and there's no sass-embedded for arm64. |
sass-embedded works ok on Windows. This has something to do with load paths. He's using the jruby-complete package and rake is bundled inside of it. perhaps this change? #7683 it's just a hard guess... |
@ahorek ouch. I think I see the problem. Blindly using java.io.File will probably see uri:classloader as a relative file and then make a very strange absolute path. |
Fixes #7717. sass-embedded gem extension install fails with jruby-com…
@chadlwilson I did not have exact same env to test this but the test I did was trying and install using --user-install. This will still fail but it fails in the same way as 9.4.1.0 did so I think the damage had been undone. You are likely using the windows installer but you should be able to install our nightly (zip) to verify things are fixed for you: https://www.jruby.org/nightly (note: nightly will mean testing tomorrow since I just merged it). |
Thanks @enebo - we run by the jruby complete jar not an installer so I'll figure out how to drop that in and sanity test. |
The complete jar is built and published to the Sonatype snapshots repository every night too! |
Thanks folks, looks fine to me now on Windows 11 with |
Environment Information
Provide at least:
jruby 9.4.2.0 (3.1.0) 2023-03-08 90d2913fda OpenJDK 64-Bit Server VM 17.0.6+10-LTS on 17.0.6+10-LTS [aarch64-mswin32]
(similar on[x86_64-mswin32]
)Windows 2022 Server Core
/Windows 11
Other relevant info:
2.3.25
1.58.3
Expected Behavior
Can install
sass-embedded
gem and run its "native extensions" install as before.Actual Behavior
A gem install of sass-embedded on Windows seems to now fail with the below error. This is working on JRuby
9.4.1.0
.sass-embedded uses a "native extension" to dynamically download appropriate native sass binaries for Windows to run within JRuby via this Rakefile.
There seems to be some issue when requiring
rake
? I can't see obviously from https://www.jruby.org/2023/03/08/jruby-9-4-2-0.html what might have changed to cause this - there might be issue on our side of course.bundle install
log (run via Jruby)gem_make.out
log (similar to above)JRuby is being launched with the below as
C:/gocd/server/scripts/jruby.bat
(don't ask me about the history here 😅)The text was updated successfully, but these errors were encountered: