Loading activerecord-jdbcmysql-adapter crashes in JRuby 9.4.6.0 #8116
Comments
|
The base problem is: module Foo
end
Foo.module_eval {
@@a = 1
}This should raise in Ruby 3.1.x. I will try and get new releases out for mysql soon. |
That would be much appreciated; I'm also running into this issue. |
|
@mohamedhafez @Confusion Sorry this got lost |
|
61.3 has been released. If there is any other problem we will try and get the turnaround much quicker |
|
@enebo Will versions 60.x and 70.x of activerecord-jdbc-adapter also get patch releases? I'm running tests for sequel-activerecord_connection on Active Record 6.0+ on JRuby, and now 6.1 is passing but 6.0 and 7.0 are failing with this error. |
|
@janko are you sure 70.2 is not working? https://rubygems.org/gems/activerecord-jdbc-adapter/versions/70.2-java I had released that at the same time and it should have gotten the same fix. I wasn't planning on updating 60.x but I can do that if you are still supporting it. |
|
Oh, you're right, the AR 7.0 test failed the same day JDBC adapter 70.2 was released, so it was still running 70.1 👍🏻 As for AR 6.0, I can just drop support for it on JRuby, people can just upgrade to AR 6.1. |
|
@janko I am adding a couple of commits for 60 so I will put something out this morning. It looks like we are also still using starts_with? which I think Rails 6 removed. It will only effectively change sqlite3 (although unfortunately we end up releasing all adapters whether they change or not). |
|
Cool, thanks 👍🏻 FWIW, for me only the mysql2 adapter tests produce this error, sqlite3 works without issues. |
|
@janko I take that back. There are other odd issues popping up. I am afraid to put something new out now. Something got deprecated and I can see someone changed general deps during 61 to include byebug. In general our policy for this is to not support anything Rails no longer supports itself and 6.0.x fell off the support table. |
|
@janko mysql2? Really? Can you attach a gist. I only changed the cvar thing for sqlite3 and did not know we had that problem in mysql. Perhaps we addressed it for 70 before someone noticed it happening in sqlite3 |
|
Here are the failing tests for the JRuby & AR 6.0 combination on my gem – https://github.com/janko/sequel-activerecord_connection/actions/runs/8618276360/job/23620255703. Some are legit failures, but most are |
|
Yeah, Active Record 6.0 being EOL is a completely legit reason for stopping support for it 👍🏻 I'm just used to supporting EOL versions of Rails & Ruby in my gems until they start posing a significant maintenance burden. |
|
@janko ok interesting this on 60-stable is already fixed for mysql: ee5562663 (Thomas E. Enebo 2024-02-21 10:03:30 -0500 125) MYSQL_ENCODINGS =
```
LOL. I do not remember doing this. So unless someone is desparate for another 60.x we will not be putting anything out. The fixes are still here but I can see a potential sweater unravelling. So let's say 60.x is done. |
Running
rails new . -d mysqlfails with the following error, and the stacktrace at the bottom on JRuby 9.4.6.0, but works fine in 9.4.5.0. (Just trying to run the rails console in my application fails with the same error, just figured this was more reproducible)Environment Information
JRuby version (
jruby -v) and command line (flags, JRUBY_OPTS, etc)jruby 9.4.6.0 (3.1.4) 2024-02-20 576fab2 OpenJDK 64-Bit Server VM 17.0.10+7-LTS on 17.0.10+7-LTS +jit [arm64-darwin]
Operating system and platform (e.g.
uname -a)Darwin Mohameds-MacBook-Pro.local 23.3.0 Darwin Kernel Version 23.3.0: Wed Dec 20 21:30:44 PST 2023; root:xnu-10002.81.5~7/RELEASE_ARM64_T6000 arm64
mysql -V
mysql Ver 8.0.36 for macos14.2 on arm64 (Homebrew)
Other relevant info you may wish to add:
Installed or activated gems
activerecord-jdbcmysql-adapter 61.2
Application/framework version (e.g. Rails, Sinatra)
rails 6.1.7.6
Expected Behavior
creates a fresh rails project successfully
Actual Behavior
The text was updated successfully, but these errors were encountered: