Fix count_spec (1.7.x) #1231
Fix count_spec (1.7.x) #1231
Conversation
Use the appropriate arity to get Enumerable#count to handle its args correctly. Note that we need to switch from JavaInternalBlockBody to a BlockCallback since JavaInternalBlockBody does not currently get its arguments prepared correctly for the given arity.
|
There seems to be a conflict on the 1.7 branch with another commit of yours. Can you look into that? It appears that the count18 path is using 1.9 behavior, calling #size if present. |
|
The call to |
|
If that's appropriate behavior for 1.8, then there's no problem. See if you can tidy up the PR and we'll pull it in. |
|
Okay, now I'm definitely missing something :) I'm not sure what to tidy... the pull looks correct to me. Can you hit me with a bit more detail on what you're seeing? I'd be glad to fix anything up. |
|
cherry-picked this since this ui implies this was against master and not jruby-1_7. |
|
Ah! That explains the confusion... my bad for sending this to the wrong branch by accident. Thanks for clearing things up @enebo. |
Use the appropriate arity to get Enumerable#count to handle its args correctly. Note that we need to switch from JavaInternalBlockBody to a BlockCallback since JavaInternalBlockBody does not currently get its arguments prepared correctly for the given arity (this is fixed in master).
This does not need to be merged into master since #1230 takes care of it.