Code cleanups 3rd try

[qmx]

this time following wmeissner's performance tips

[enebo]

whoops...I should have put a comment when I closed this that I applied all three patches. The RubyModule one I did a minor tweak from getRuntime() to runtime since your new method passes runtime in.

[qmx]

looks like 4068b5f got lost :(

[enebo]

I will land this after lunch...very odd...I know I cherry-picked it. I was curious about the patch since you deprecated the method and then made the non-deprecated method call it. I figured I would see a deprecation warning during compilation (but didn't perhaps because I did not actually cherry pick it?)

[enebo]

Yeah that last patch needs to be changed. Otherwise we will have one more deprecation warning each time we compile JRuby.

  [apt] /Users/enebo/work/jruby/src/org/jruby/embed/variable/ClassVariable.java:177: warning: [deprecation] removeCvar(org.jruby.runtime.builtin.IRubyObject) in org.jruby.RubyModule has been deprecated
  [apt]         rubyClass.removeCvar(rubyName);

[qmx]

It was like this before: #16

wmeissner told me to use removecvar to spare the ThreadLocal call

[enebo]

I am not a huge fan of Java code calling @jruby_method bound methods directly since most of those methods usually do more than a Java caller would want (not in this case though).

In general we have a set of lower level methods which are meant to Java callers to use and we have a set of JRubyMethods which typically process IRubyObject arguments and do coercions. The bigger problem with removeCVar is it should have been 'public IRubyObject removeCvar(String name)'. So I think the patch should @deprecate removeCvar...create a new removeClassVariable(String name). Change removeCVar and remove_class_variable to both call removeClassVariable. Change ClassVariable.remove to call removeClassVariable also (notice the smell at that callsite? We construct a RubyString based on name to remove the variable).

[qmx]

I've did the modifications here

qmx@c11a215