enhanced the java_class compiler so it can handle multiple constructors #1762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change would allow you to create multiple Java constructors for a Ruby class like so:
Such a capability is required for Java frameworks that require a no-arg constructor, even if your application code doesn't use it.
The call to
java_signature.is_a?(Java::OrgJrubyAstJava_signature::ConstructorSignatureNode)
in the java_class compiler is a little unfortunate. I'd prefer to add anisConstructor
method to SignatureNode and override it to return true in ConstructorSignatureNode. I will update this PR with that change if it's desired.Also, I can reopen this PR against master if needed.