Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Process#groups for non-Windows machines #2082

Merged
merged 1 commit into from Nov 4, 2014

Conversation

cheald
Copy link
Contributor

@cheald cheald commented Nov 3, 2014

Implements Process#groups. This relies on the com.sun.security.auth.module.UnixSystem class, which is only present in *nix distributions of the JRE; it is actually not present on Windows (a similar NTSystem module is instead present).

I've attempted to build JRuby on Windows, but my Windows build environment is sadly not up to date. However, based on some Googling, avoiding the import and instead referencing the full package name at runtime should allow the project to compile on Windows while still avoiding referencing classes that don't exist at runtime.

@headius
Copy link
Member

headius commented Nov 4, 2014

This may or may not work to build on Windows, but we will have to cross the "building on Windows" bridge sooner rather than later. If it turns out this doesn't work, we can turn it into full reflection or use some other mechanism (mock library) to provide the functionality.

@headius headius added this to the JRuby 9000 milestone Nov 4, 2014
@headius headius added the core label Nov 4, 2014
@headius headius self-assigned this Nov 4, 2014
headius added a commit that referenced this pull request Nov 4, 2014
Implement Process#groups for non-Windows machines
@headius headius merged commit 7029b00 into jruby:update_stdlib Nov 4, 2014
@headius
Copy link
Member

headius commented Nov 4, 2014

Thank you!

@cheald cheald deleted the process_groups branch November 4, 2014 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants