Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exponential expansion of work in method lookup #2218

merged 1 commit into from
Nov 19, 2014


Copy link

@cheald cheald commented Nov 18, 2014

Fix for #2217. I'm not quite sure I grok the whole setup here (particularly with respect to the prepend work being done), but it fixes the issue nicely and returns method lookup to linear time.

There are module failures in the test suite, but they were introduced in 98fa7a6.

enebo added a commit that referenced this pull request Nov 19, 2014
Fix exponential expansion of work in method lookup
@enebo enebo merged commit e63015b into jruby:master Nov 19, 2014
Copy link

tduehr commented Nov 19, 2014

as long as the tests pass this will be fine for the current prepend. This code should have been recurring anyway due to the linear nature of inheritance right now. This recursion was needed for the other version of prepend. I hadn't trimmed it because it should have been inert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants