Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary puts for GC::Profiler.total_time #2292

Merged
merged 1 commit into from Jan 12, 2015

Conversation

Projects
None yet
2 participants
@zanker
Copy link

zanker commented Dec 9, 2014

Calling GC::Profiler.total_time dumps the headers used by GC::Profiler.result when the GC::Profiler::NotifiedProfiler is being used. Given the method doesn't dump anything, it looks like this isn't needed and could be dropped.

@headius

This comment has been minimized.

Copy link
Member

headius commented Jan 12, 2015

You're right, looks like copypasta.

headius added a commit that referenced this pull request Jan 12, 2015

Merge pull request #2292 from zanker/jruby-gc-profiler-puts
Remove unnecessary puts for GC::Profiler.total_time

@headius headius merged commit 67c9b29 into jruby:master Jan 12, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@headius headius added this to the JRuby 1.7.19 milestone Jan 12, 2015

@headius headius self-assigned this Jan 12, 2015

headius added a commit that referenced this pull request Jan 12, 2015

Merge pull request #2292 from zanker/jruby-gc-profiler-puts
Remove unnecessary puts for GC::Profiler.total_time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.