Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truffle-related clean up and simplifications. #2422

Merged
merged 6 commits into from
Jan 4, 2015
Merged

Truffle-related clean up and simplifications. #2422

merged 6 commits into from
Jan 4, 2015

Conversation

thomaswue
Copy link
Contributor

Please review, @chrisseaton. Thanks!

final RubyContext finalContext = context;

final ThreadLocal threadLocal = new ThreadLocal() {
final ThreadLocal<Object> threadLocal = new ThreadLocal<Object>() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use the diamond operator on the RHS of this: new ThreadLocal<>()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was thinking the same, but the diamond operator is unfortunately not supported by javac for anonymous classes.

chrisseaton added a commit that referenced this pull request Jan 4, 2015
Truffle-related clean up and simplifications.
@chrisseaton chrisseaton merged commit e0ea4e8 into jruby:master Jan 4, 2015
@chrisseaton chrisseaton modified the milestone: truffle-dev May 4, 2015
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants