Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Including RegexpOptions in RubyRegexp #2631

merged 3 commits into from Feb 28, 2015


Copy link

@bjfish bjfish commented Feb 28, 2015

to be able to return more correct options from the options method.

return getContext().getCoreLibrary().getNilObject();

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we factor this out into a helper method that takes two ByteList objects?

chrisseaton added a commit that referenced this pull request Feb 28, 2015
[Truffle] Including RegexpOptions in RubyRegexp
@chrisseaton chrisseaton merged commit 1a744fa into jruby:master Feb 28, 2015
Copy link

Thanks! In the future, if not too much of a hassle, please split different method implementations into different commits. We've had to revert method implementations in the past because of failing benchmarks and what not. It's just much easier to cope with that if the commits are more scoped in nature. I usually use "git add -p" to do it if I've been working in a file for a while. But, if it gets to hairy, a holistic commit like this is fine -- we're pragmatic.

@chrisseaton chrisseaton modified the milestone: truffle-dev May 4, 2015
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants