Skip to content

Conversation

@bjfish
Copy link
Contributor

@bjfish bjfish commented Apr 6, 2015

I don’t believe this is used in any benchmarks but wasn’t 100% sure.

@chrisseaton
Copy link
Contributor

Can you try chunky-canvas-resampling-steps-residues and chunky-canvas-resampling-steps - they both use #round. Then also chunky-canvas-resampling-nearest-neighbor and chunky-canvas-resampling-bilinear, which use those methods.

@chrisseaton chrisseaton added this to the truffle-dev milestone Apr 6, 2015
@bjfish bjfish force-pushed the truffle_float_round branch from 3488873 to b9d7b7f Compare April 6, 2015 15:35
@bjfish
Copy link
Contributor Author

bjfish commented Apr 6, 2015

@chrisseaton The first benchmark I tried had regressed to 20% chunky-canvas-resampling-steps-residues so I added back the java specialization and a fallback to ruby specialization which brought the benchmark back to 100%. I didn't try the other three benchmarks but I assumed they would be okay if the first regression was fixed.

chrisseaton added a commit that referenced this pull request Apr 6, 2015
[Truffle] Move Float#round to float.rb
@chrisseaton chrisseaton merged commit 1acb1f0 into jruby:master Apr 6, 2015
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants