Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Move Float#round to float.rb #2806

merged 1 commit into from Apr 6, 2015


Copy link

@bjfish bjfish commented Apr 6, 2015

I don’t believe this is used in any benchmarks but wasn’t 100% sure.

Copy link

Can you try chunky-canvas-resampling-steps-residues and chunky-canvas-resampling-steps - they both use #round. Then also chunky-canvas-resampling-nearest-neighbor and chunky-canvas-resampling-bilinear, which use those methods.

@chrisseaton chrisseaton added this to the truffle-dev milestone Apr 6, 2015
Copy link
Contributor Author

bjfish commented Apr 6, 2015

@chrisseaton The first benchmark I tried had regressed to 20% chunky-canvas-resampling-steps-residues so I added back the java specialization and a fallback to ruby specialization which brought the benchmark back to 100%. I didn't try the other three benchmarks but I assumed they would be okay if the first regression was fixed.

chrisseaton added a commit that referenced this pull request Apr 6, 2015
[Truffle] Move Float#round to float.rb
@chrisseaton chrisseaton merged commit 1acb1f0 into jruby:master Apr 6, 2015
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants