Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Adding fallback Specialization for Fixnum#<. #2808

merged 1 commit into from Apr 7, 2015


Copy link

@bjfish bjfish commented Apr 7, 2015

For example, jruby -X+T -e 'puts 1 < Rational(“1.3”)’

Copy link

Can't we just do ruby("b, a = math_coerce other, :compare_error; a < b") - the separate fallback code and the extra primitive (which always just fails) seem like a lot of extra work for this.

@chrisseaton chrisseaton added this to the truffle-dev milestone Apr 7, 2015
Copy link
Contributor Author

bjfish commented Apr 7, 2015

@chrisseaton Yes, I've updated the PR.

chrisseaton added a commit that referenced this pull request Apr 7, 2015
[Truffle] Adding fallback Specialization for Fixnum#<.
@chrisseaton chrisseaton merged commit daa3539 into jruby:master Apr 7, 2015
@bjfish bjfish deleted the truffle_fixnum_less_than branch April 7, 2015 14:23
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants