Add some more tests for bignum pow #3120

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@skmp
Contributor

skmp commented Jul 8, 2015

I added tests for checking two more currently failing scenarios triggering ArithmeticExceptions instead of returning Infinity.
I am not sure if this is the right place for adding these as these tests are taken over from MRI if I understand correctly. Can you provide some guidance here?

@eregon

This comment has been minimized.

Show comment
Hide comment
@eregon

eregon Jul 14, 2015

Member

This would be nice to have in rubyspec, in https://github.com/jruby/jruby/blob/master/spec/ruby/core/bignum/exponent_spec.rb for instance.

Member

eregon commented Jul 14, 2015

This would be nice to have in rubyspec, in https://github.com/jruby/jruby/blob/master/spec/ruby/core/bignum/exponent_spec.rb for instance.

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Nov 13, 2015

Member

on master as 9a7dc0d ... thanks @skmp

Member

kares commented Nov 13, 2015

on master as 9a7dc0d ... thanks @skmp

@kares kares closed this Nov 13, 2015

@kares kares added this to the JRuby 9.0.5.0 milestone Nov 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment