Fix GzipWriter output #3421
Merged
Fix GzipWriter output #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GZIPOutputStream was passing one of its internal byte buffers to IOOutputStream#write, which in turn used those bytes to back the ByteList for its output. So every subsequent time GZIPOutputStream wrote to that buffer, it overwrote the bytes behind the back of all the previous chunks of output. Ensure that IOOutputStream is working on a copy of the bytes it gets from GZIPOutputStream to fix this issue.
Typo'ed variable reference should have caused problems, but got lucky and the only place calling this `write` passes 0 for `off` so everything just happens to always work in spite of looking so, so wrong.
|
Just pushed a small extra change on this pull: b2dc3da. Apologies for the noise. |
|
Just saw Travis is showing red on this pull because the 1_7 branch went red while I was working on this. See here for a green run of these changes: https://travis-ci.org/dmarcotte/jruby/builds/87085859 |
|
☝️ very najs find - much appreciated! |
|
Thanks @kares! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GZIPOutputStream was passing one of its internal byte buffers to IOOutputStream#write, which in turn used those bytes to back the ByteList for its output. So every subsequent time GZIPOutputStream wrote to that buffer, it overwrote the bytes behind the back of all the previous chunks of output.
Ensure that IOOutputStream is working on a copy of the bytes it gets from GZIPOutputStream to fix this issue.
Fixes #1371
Let me know if there's any questions, and thanks again!