Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper support for UNIXSocket.for_fd #3494

Merged
merged 1 commit into from Dec 26, 2015

Conversation

Projects
None yet
2 participants
@mrbrdo
Copy link
Contributor

commented Nov 24, 2015

for_fd method

@mrbrdo

This comment has been minimized.

Copy link
Contributor Author

commented Dec 24, 2015

Regarding specs, the only test that covers this is for_fd_spec.rb, but it also uses the path method, which is not implemented on JRuby. That could probably be implemented with jnr/jnr-unixsocket#24

@mrbrdo mrbrdo force-pushed the mrbrdo:unixsocket_for_fd branch from 7ccb626 to 5beeabe Dec 24, 2015

headius added a commit that referenced this pull request Dec 26, 2015

Merge pull request #3494 from mrbrdo/unixsocket_for_fd
Proper support for UNIXSocket.for_fd

@headius headius merged commit 2b67b11 into jruby:master Dec 26, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@headius headius added the stdlib label Dec 26, 2015

@headius headius added this to the JRuby 9.0.5.0 milestone Dec 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.