Proper support for UNIXSocket.for_fd #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding specs, the only test that covers this is for_fd_spec.rb, but it also uses the path method, which is not implemented on JRuby. That could probably be implemented with jnr/jnr-unixsocket#24 |
mrbrdo
force-pushed
the
unixsocket_for_fd
branch
from
7ccb626
to
5beeabe
Compare
headius
added a commit
that referenced
this pull request
Dec 26, 2015
Proper support for UNIXSocket.for_fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for_fdmethod