Test new recursion #3896
Merged
Test new recursion #3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headius
force-pushed
the
test-new-recursion
branch
from
9530b33
to
b80b147
Compare
|
I have squashed all commits into one, since they didn't really add anything interesting to history. |
|
looking good to me ... the new logic seems much easier to follow 👍 |
The old recursion guard (ported from MRI years ago) had a number of flaws: * It forced an object ID for every object encountered. * It created transient objects for every recursive stack. * It was not using identity hashing (#3887). * It used a RubyHash internally, which has much more overhead than a typical JDK Map. The new implementation largely follows the pattern of the original but fixes all the above items. It passes all untagged specs. See also #3884, which started this whole thing.
headius
force-pushed
the
test-new-recursion
branch
from
b80b147
to
dc7c489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dunno if anyone wants to review this (e.g. @enebo or @kares) but it appears to have passed all tests and eliminates some really ugly misfeatures of the original port.
Note that I have not removed the old impl in case an external library uses it.