Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
The old recursion guard (ported from MRI years ago) had a number of flaws: * It forced an object ID for every object encountered. * It created transient objects for every recursive stack. * It was not using identity hashing (#3887). * It used a RubyHash internally, which has much more overhead than a typical JDK Map. The new implementation largely follows the pattern of the original but fixes all the above items. It passes all untagged specs. See also #3884, which started this whole thing.
headius merged commit
May 19, 2016
0 of 4 checks passed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.