Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #482 Array#zip with infinite enum results in OOM #485

Merged
merged 3 commits into from Jan 11, 2013

Conversation

Projects
None yet
3 participants
@isaiah
Copy link
Contributor

commented Jan 7, 2013

see #482

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Jan 7, 2013

Looks good. Could you add test cases? They can go into spec/regression.

@atambo

This comment has been minimized.

Copy link

commented on src/org/jruby/RubyArray.java in 18aac56 Jan 7, 2013

Is this import used?

This comment has been minimized.

Copy link
Owner

replied Jan 7, 2013

No, introduced by ide, I'll remove it with the tests, thanks for pointing that out.

Isaiah Peng
[1,2].zip([0]).should == [[1,0],[2,nil]]
end

it "another array append block is yield with corrent argument" do

This comment has been minimized.

Copy link
@BanzaiMan

BanzaiMan Jan 9, 2013

Member

Perhaps you meant: "…is yielded with correct argument"

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Jan 9, 2013

Thanks for the specs. We are almost there. 😃

BanzaiMan added a commit that referenced this pull request Jan 11, 2013

Merge pull request #485 from isaiah/master
Resolve #482 Array#zip with infinite enum results in OOM

@BanzaiMan BanzaiMan merged commit b0a6a92 into jruby:master Jan 11, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.