Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #482 Array#zip with infinite enum results in OOM #485

Merged
merged 3 commits into from Jan 11, 2013
Merged

Resolve #482 Array#zip with infinite enum results in OOM #485

merged 3 commits into from Jan 11, 2013

Conversation

isaiah
Copy link
Contributor

@isaiah isaiah commented Jan 7, 2013

see #482

@BanzaiMan
Copy link
Member

Looks good. Could you add test cases? They can go into spec/regression.

BanzaiMan
BanzaiMan reviewed Jan 9, 2013
View reviewed changes
spec/regression/gh-482_array_zip_cycle.rb
[1,2].zip([0]).should == [[1,0],[2,nil]]
end

it "another array append block is yield with corrent argument" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you meant: "…is yielded with correct argument"

@BanzaiMan
Copy link
Member

Thanks for the specs. We are almost there. 😃

BanzaiMan added a commit that referenced this pull request Jan 11, 2013
@BanzaiMan
Merge pull request #485 from isaiah/master
b0a6a92 
Resolve #482 Array#zip with infinite enum results in OOM
@BanzaiMan BanzaiMan merged commit b0a6a92 into jruby:master Jan 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
JRuby 1.7.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@isaiah @BanzaiMan @atambo