Skip to content

/ jruby

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set MetaClass of cloned object #4919

Merged
merged 1 commit into from Jan 1, 2018
Merged

Set MetaClass of cloned object #4919

merged 1 commit into from Jan 1, 2018

Conversation

@yui-knk
Copy link
Contributor

@yui-knk yui-knk commented Dec 30, 2017

In MRI, method_clone uses CLASS_OF method objects

clone = TypedData_Make_Struct(CLASS_OF(self), struct METHOD, &method_data_type, data);

By this change, TestMethod#test_clone will be passed.
@yui-knk
Set MetaClass of cloned object
Loading status checks…
ea1f8a8 
In MRI, `method_clone` uses CLASS_OF method objects

```
clone = TypedData_Make_Struct(CLASS_OF(self), struct METHOD, &method_data_type, data);
```

By this change, `TestMethod#test_clone` will be passed.
@kares
Copy link
Member

@kares kares commented Jan 1, 2018

Makes sense. Thanks Yui.
@kares kares merged commit 0a9dc53 into jruby:master Jan 1, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@kares kares added this to the JRuby 9.2.0.0 milestone Jan 1, 2018
@kares kares added the core label Jan 1, 2018
@yui-knk yui-knk deleted the yui-knk:fix_test_clone branch Jan 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
JRuby 9.2.0.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@yui-knk @kares