New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MetaClass of cloned object #4919

Merged
merged 1 commit into from Jan 1, 2018

Conversation

Projects
None yet
2 participants
@yui-knk
Contributor

yui-knk commented Dec 30, 2017

In MRI, method_clone uses CLASS_OF method objects

clone = TypedData_Make_Struct(CLASS_OF(self), struct METHOD, &method_data_type, data);

By this change, TestMethod#test_clone will be passed.

Set MetaClass of cloned object
In MRI, `method_clone` uses CLASS_OF method objects

```
clone = TypedData_Make_Struct(CLASS_OF(self), struct METHOD, &method_data_type, data);
```

By this change, `TestMethod#test_clone` will be passed.
@kares

This comment has been minimized.

Member

kares commented Jan 1, 2018

Makes sense. Thanks Yui.

@kares kares merged commit 0a9dc53 into jruby:master Jan 1, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@kares kares added this to the JRuby 9.2.0.0 milestone Jan 1, 2018

@kares kares added the core label Jan 1, 2018

@yui-knk yui-knk deleted the yui-knk:fix_test_clone branch Jan 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment