Time#at receives 3rd argument which specifies the unit of 2nd argument #5056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
requested changes
Feb 25, 2018
| String unit; | ||
| if (arg3 instanceof RubySymbol) { | ||
| unit = ((RubySymbol) arg3).toString(); | ||
| throw context.runtime.newArgumentError("unexpected unit " + arg3); |
There was a problem hiding this comment.
will always be raising whenever a unit Symbol arg is passed in
seems like the logic to validate supported units is missing here?
There was a problem hiding this comment.
@kares you were right, fixed it now!
|
@kares thanks for the review and sorry for the delay. Fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/13919
#4876