Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyword_init option to #5061

merged 1 commit into from Mar 21, 2018


Copy link

Hi folks,

This is another feature targeting Ruby 2.5 [1]: Add keyword_init option to (feature #11925).

Thanks for your review and feedback.

  1. Ruby 2.5 Support #4876

Copy link
Contributor Author

I gave a shot to the implementation of this new feature and although all existing tests (and the new ones exercising this change) in test/mri/ruby/test_struct.rb are passing, I'm probably missing something here.

I decided to test if inheritance work as expected and I wrote the following test to verify but I found out some assertions are failing:

  def test_struct_new_with_keyword_init_and_inheritance
    klass =, keyword_init: true)
    klass2 =
    assert_raise(ArgumentError) { } # broken, nothing is raised: => #<struct a=1>
    assert_nothing_raised { 5) }    # nothing is raised but is wrong as well: => #<struct a={:a=>5}>
    o = 5)                          # wrong => #<struct a={:a=>5}>
    assert_equal(5, o.a)                          # broken: o.a => {:a=>5}

Where should I look to get this working?

BTW, do you see worthwhile to contribute that extra test to MRI or ruby/spec?

Copy link

headius commented Feb 23, 2018

Thank you for the PR!

Regarding your test:

  • Contribute it to ruby/spec, ideally. It will filter back to JRuby whenever we update. ruby/spec is structured better and should always be the first place you look to contribute tests.
  • If you want to try to fix it, look at RubyStruct.createStructClass and newInstance and compare with CRuby's logic. It's possible they changed the class structure surrounding Struct and we missed it.
  • You can also defer and file a separate bug for the failing assertions, so we can get the PR in. We'll collab on fixing it in-place then.

@headius headius added this to the JRuby milestone Feb 23, 2018
Copy link
Contributor Author

@headius Thanks for the pointer, I just saw what's the problem with the inheritance in this case. I'll update the PR soon.

@nomadium nomadium force-pushed the keyword-arguments-on-struct-new branch from 10985df to dea2028 Compare February 25, 2018 19:08
Copy link
Contributor Author

@headius The issue I pointed out in my previous comment is now fixed. I'll try to submit my extra test to ruby/spec later.

throw getRuntime().newArgumentError("unknown keywords: " + unknownKeywords);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised I was reimplementing functionality already available in JRuby with these checks. I'll update this PR soon to address that.

@nomadium nomadium force-pushed the keyword-arguments-on-struct-new branch from dea2028 to bfa648a Compare March 10, 2018 20:18
For more information, please see feature #11925.
@nomadium nomadium force-pushed the keyword-arguments-on-struct-new branch from bfa648a to 6746380 Compare March 11, 2018 12:52
@nomadium nomadium mentioned this pull request Mar 20, 2018
75 tasks
@headius headius merged commit 55fa773 into jruby:ruby-2.5 Mar 21, 2018
@nomadium nomadium deleted the keyword-arguments-on-struct-new branch March 23, 2018 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants