Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thread stop #5315

merged 1 commit into from Sep 19, 2018

Remove thread stop #5315

merged 1 commit into from Sep 19, 2018


Copy link

@headius headius commented Sep 19, 2018

This PR is to resolve #1183 by replacing the remaining stop calls with interrupt calls.

This may lead to bad behavior in the threads we formerly forced to stop, but it would be better to know that these cases exist than continue to call this bad method.

@headius headius added this to the JRuby milestone Sep 19, 2018
@headius headius requested review from enebo and kares Sep 19, 2018
These stop calls were put in place during a time when the "pump"
threads were not easily interrupted. Usually this was due to
being forced to work with opaque IO streams rather than the actual
channels. At this point, with Thread#stop going away and still
causing log noise, we have decided to remove all calls.

This code was used primarily by the few remaining non-popen-based
command launches (usually which read the streams to completion and
do not need to be interrupted), and for much of IO on Windows
(since we have not finished porting native IO logic to Windows).
If the removal of these calls leads to leaky pump threads, we will
find an alternative way or prioritize the completion of native IO
on Windows.
@headius headius force-pushed the remove_thread_stop branch from 38901b8 to 79b6b33 Sep 19, 2018
enebo approved these changes Sep 19, 2018
@headius headius merged commit ffa6bbb into master Sep 19, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
continuous-integration/travis-ci/pr The Travis CI build passed
@headius headius deleted the remove_thread_stop branch Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants