Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index error instead of argument error #5337

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@ahorek
Copy link
Contributor

ahorek commented Sep 30, 2018

No description provided.

@kares

This comment has been minimized.

Copy link
Member

kares commented Oct 1, 2018

again there's no explanation nor a test on why you're doing this change.
its probably a MRI incompatibility but still would be great to have it at least mentioned.

@kares kares added this to the JRuby 9.2.1.0 milestone Oct 1, 2018

@ahorek

This comment has been minimized.

Copy link
Contributor Author

ahorek commented Oct 1, 2018

there's a test for this behavior, but it still fails for a different reason

test_aset_error

exclude :test_aset_error, "needs investigation"

def test_aset_error

should I duplicate it and test this separately in a jruby's test specs?

@kares

This comment has been minimized.

Copy link
Member

kares commented Oct 1, 2018

@ahorek that is very helpful to know, thanks.
fine with leaving it as is or you could try adding a spec/ruby for it if it makes sense.
think this can get (eventually) merged as is.

@kares kares merged commit 0767a8f into jruby:master Oct 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

holylance added a commit to holylance/jruby that referenced this pull request Oct 9, 2018

Merge pull request #69 from holylance/rebase_master
[fix] raise index error instead of argument error (jruby#5337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.