Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.28 version - update jruby-openssl version for IBM cipher fix #5359

Closed
wants to merge 2 commits into from

Conversation

jkuchta
Copy link

@jkuchta jkuchta commented Oct 11, 2018

Create a 1.7.28 JRuby version with updated jruby-openssl for IBM JDK SSL cipher support (fixed in jruby-openssl 0.9.21).

@kares
Copy link
Member

kares commented Oct 12, 2018

seems it can't just stay dead already :) ... is it problematic for you to simply upgrade jossl after install?
... also if you specify in Gemfile it will use that

@jkuchta
Copy link
Author

jkuchta commented Oct 12, 2018

I know ;-)

Unfortunately, we have a legacy application that gets warbled so even when including a new jruby-openssl version in the Gemfile it still uses the version that is included in jruby-jars. Long-term I want to move to JRuby 9.2.x.x but the upgrade breaks a lot of legacy code and will require more time to complete.

@kares
Copy link
Member

kares commented Oct 12, 2018

Unfortunately, we have a legacy application that gets warbled so even when including a new jruby-openssl version in the Gemfile it still uses the version that is included in jruby-jars. Long-term I want to move to JRuby 9.2.x.x but the upgrade breaks a lot of legacy code and will require more time to complete.

@jkuchta hmm, that is weird ... last year I upgraded a warbling app from 1.7 to 9K and I recall (while preparing for upgrade and fixing security bugs) having 1.7 with a jruby-openssl version specified in Gemfile running just fine ... I know there has been such issues with 1.7 line but few latest releases were working.

@jkuchta
Copy link
Author

jkuchta commented Oct 12, 2018

@kares agreed. We are currently on 1.7.27 - which has jruby-openssl 0.9.18 and the first version of jruby-openssl that seems to support the IBM ciphers is 0.9.21. In the Gemfile I've included openssl 0.10.1 which works when running the project (rails) directly but does not work once warbled.

@headius
Copy link
Member

headius commented Oct 12, 2018

If you have time to explain what breaks upgrading to 9x that would be great. I'm not sure we have the resources or inclination to try to push a 1.7.28 but most of that falls on @enebo.

@jkuchta
Copy link
Author

jkuchta commented Oct 12, 2018

@headius sure, the main issue is Warbler fails with a stack overflow on our user model. I suspect this is something related to having to upgrade Devise from 3.x to 4.x. Separate from that there are a handful of other gem updates required that would need a bit of refactoring (these aren't nearly as bad as the Warbler issue).

As far as the 1.7.28 - is there anything else needed here besides changing the 1.7.28-SNAPSHOT versions to 1.7.28? The change itself is fairly small but adding those IBM ciphers would be a big help to give more time for a smoother transition to 9.2.x.x.

@kares
Copy link
Member

kares commented Oct 13, 2018

its been EOL for a while, thus maybe if you really need to stay on 1.7 using IBM Java maybe we shall insteadclook into getting the upgraded jossl working when Warbled ... worst case scenario is to repackage the archive bits.

@jkuchta
Copy link
Author

jkuchta commented Oct 15, 2018

@kares as far as repackaging, are you refering to the jruby-stdlib and just replacing the jopenssl.jar?

@kares
Copy link
Member

kares commented Oct 16, 2018

that would be an option yes - having your own stdlib.jar around that you would replace.
other one is to understand why its not picking up the declared .jar which is likely a servlet container issue, maybe also solvable by changing RGs version used. if you need support around, feel free to get in touch.

@jkuchta
Copy link
Author

jkuchta commented Oct 16, 2018

@kares thanks - is there a way I can print what jruby-openssl version is being used?

@kares
Copy link
Member

kares commented Feb 12, 2020

any objections against closing this one? as there are no planned JRuby 1.7.x releases.

@kares kares added this to the Invalid or Duplicate milestone Feb 12, 2020
@kares kares closed this Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants