Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi-arity method binding. #5455

Merged
merged 2 commits into from Nov 19, 2018
Merged

Fix multi-arity method binding. #5455

merged 2 commits into from Nov 19, 2018

Commits on Nov 19, 2018

  1. Fix multi-arity method binding. 

    We have apparently not been binding multi-arity rest methods well
for some time; the logic to look for "hasVarargs" was not using
the correct class.getName() for an IRubyObject[], resulting in
any variable-arity-or-rest methods always getting routed to the
rest path, because the min/max logic breaks without hasVarargs.
    @headius
    headius committed Nov 19, 2018
    Copy the full SHA
    c025bbb View commit details
    Browse the repository at this point in the history

  2. Fix missing kwarg-init errors and move internal var names to const

    @headius
    headius committed Nov 19, 2018
    Copy the full SHA
    12e89f4 View commit details
    Browse the repository at this point in the history