Fail gracefully when inner class const_missing finds nothing #5835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic here does not properly handle the case where the inner class does not resolve to anything. When this happens, the proxy class is null, which has a java_class of nil, and then it blows up trying to cast it.
kares
approved these changes
Aug 16, 2019
|
Test added in a118fe8. |
Adithya-copart
pushed a commit
to Adithya-copart/jruby
that referenced
this pull request
Aug 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue reported as a comment in ruboto/JRuby9K_POC#7.
The issue here appears to be that non-existent inner classes are not handled properly; the resulting null or nil values fail to cast to expected types and the superclass const_missing fallback never triggers.
The change I have here uses a different path for acquiring a reference to the proxy class, which then allows the fallback to fire properly.
The original change was made by @kares in #3333 but it appears the test cases added did not test the case where there is no inner class for the constant.