[jit] replace method invocation counter with jit.time.delta #5887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…been reached BUT it has taken longer than -Xjit.time.delta ns since the last time saved when the counter was set to 0. This is totally untuned in that I made up a number and it I suspect is too dramatically not JITting methods. In running an oj bench and gem list (with and without --dev) and starting up rails the times do not appear to be much different. After tuning the value (which I guess would be for this machine -- a follow up to this work will be whether one magic constant can work here) which would be figuring out proper time delta and also determing whether any important methods which should have JITted had not there is a followup change I want to try: change threshold to be more than just a method call counter. I would like to also add threadpolls as an increment value. Then larger methods which are not called as much will end up as JIT candidates.
and also a way to disable System.nanoTime checking when < 0
kares
force-pushed
the
counter_nuke-clean
branch
from
e0b270e
to
8083987
Compare
|
should be ready now, it could use an com.headius:options release to get rid of the LongOption class |
|
I believe this is safe but without pushback I am skipping for somewhat imminent 9.2.10.0. |
|
I merged latest master into this to see where we stand on it, but I don't see us making this change right before 9.3. |
|
we did not do a lot of experiments with |
kares
changed the title
|
Untargeting until we have a specific release in mind. @kares Let us know what you think we should do here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is @enebo's work from https://github.com/jruby/jruby/tree/counter_nuke
rebased + with a few touches for usability (able to specify jit.time.delta as long)
might need more work as we still do not have real-world numbers (hopefully soon).
... or we can add it into next 9.2 but having jit.time.delta = -1 (disabled) by default?