Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate ThreadContext through to_a implementations #5958

Merged
merged 3 commits into from Nov 7, 2019
Merged

Propagate ThreadContext through to_a implementations #5958

merged 3 commits into from Nov 7, 2019

Commits on Nov 5, 2019

  1. Propagate ThreadContext through to_a implementations 

    This avoids bouncing through the metaClass to get the runtime,
which happens in these methods and in several downstream calls.
Several cases also needed the context, so this saves the extra
overhead of traversing the runtime, thread service, and thread
local to get the context.
    @headius
    headius committed Nov 5, 2019
    Copy the full SHA
    c186167 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2019

  1. Fix lost signatures and overrides throughout.

    @headius
    headius committed Nov 7, 2019
    Copy the full SHA
    d0e6667 View commit details
    Browse the repository at this point in the history

  2. Propagate context through Enumerator's SizeFn. 

    Most of these cases were improperly saving the context at the
point of contructing the size function.
    @headius
    headius committed Nov 7, 2019
    Copy the full SHA
    1375b2a View commit details
    Browse the repository at this point in the history