Fix Enumerator fiber leaks #6021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazy enumerators still may leak in the presence of Enumerator#next calls, but this at least isolates the instantiating Lazy from the newly-created Lazy, avoiding a backreference that might keep the original object alive. Given a test as shown in jruby#6004 that spins up many Lazy instances, this patch appears to work well. It did not appear to fix the reported leaks in that issue, however. Example code that leaked before but is stable with this patch: ```ruby while true [1,2,3].lazy.reject {|x| x < 3 }.next JRuby.gc end ```
|
In the interest of improving things for 9.2.10 I have merged this. There's still known leaks in lazy enumerators and the root cause of #6004 remains elusive but it is a step forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will include commits to reduce the chance of
Enumerator#nextfibers leaking.The original issue is #6004.
So far most of the leaks appear to be caused by combining
Enumerator::LazywithEnumerator#next, since many lazy paths construct new Lazy instances in such a way that they are hard-referenced by the eventual fiber.