Use normalized URI for glob #6427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The createResource call here normalizes a URI like "classpath:" to our preferred "uri:classloader:" but only uses that normalized version to check the existence of the resource in question. If the resource exists, it proceeds to use the un-normalized version in glob, and fails since "classpath:" is not supported by our glob internals. This patch uses the newly normalized path when calling glob internals, so "classpath:" never leaks into that code. Fixes jruby#6421
Not directly related to jruby#6421 but found along the way.
|
Clearly this needs another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dir.glob logic did not use the normalized URI form when calling glob internals, and since those internals do not support "classpath:" it ended up raising an IllegalArgumentException as reported in #6421.
This change should be benign, but my concern lies in having to call "getAbsolutePath" to get the normalized URI back.
This may be worth including in 9.2.14.