Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ji] bind interface default methods #6484

Merged
merged 5 commits into from Dec 7, 2020
Merged

[ji] bind interface default methods #6484

merged 5 commits into from Dec 7, 2020

Conversation

kares
Copy link
Member

@kares kares commented Dec 4, 2020

JRuby simply ignored any instance methods on interfaces, however this is incorrect due default methods.

resolves #6479

@kares kares added this to the JRuby 9.3.0.0 milestone Dec 4, 2020
headius
headius approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@headius headius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, not much of a change required!

@headius
Copy link
Member

headius commented Dec 4, 2020

Looks great to me, nice simple change. Merge as you see fit.

@kares
Copy link
Member Author

kares commented Dec 6, 2020

realized we need another piece of specs here to test interface method invocation with a Ruby target.

@kares kares merged commit 839a3b7 into jruby:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headius headius headius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.3.0.0
Development

Successfully merging this pull request may close these issues.

Java Interface Default methods not properly supported
2 participants
@kares @headius