Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wiki URLs to point directly to pages in warning messages #6707

Merged
merged 4 commits into from Jun 7, 2021

Conversation

olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Jun 7, 2021

While investigating an issue, socketry/falcon#64, elsewhere, I found that in warnings emitted by JRuby, the direct link to a specific wiki page link had become out of date, and didn't point to the exact page anymore. It just pointed to the start page.

With this change, it does again point to the exact pages.

TODO

Here are other files that need a change, please make that change, if you find that before I do. Have a nice day!

Without this URL, no direct link to the page is being created.
This change makes it point to an actual page.
Without this change, the page in the wiki becomes the start page.
@olleolleolle olleolleolle changed the title Update URL to ServerSocket wiki page in warning Update wiki URLs to point directly to pages in warning messages Jun 7, 2021
@headius headius merged commit 5aa7a0d into jruby:master Jun 7, 2021
@headius headius added this to the JRuby 9.3.0.0 milestone Jun 7, 2021
@olleolleolle olleolleolle deleted the patch-2 branch June 7, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants