Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ostruct tests/specs due to reverted gem #6835

merged 3 commits into from Sep 16, 2021


Copy link

@headius headius commented Sep 15, 2021

See ruby/ostruct#30 for the ostruct issue that caused us to revert to an earlier gem. This PR reverts the test and tags the specs that do not pass on the older version of ostruct.

See also #6831.

Because of ruby/ostruct#30 we were
forced to revert to an older ostruct gem (which matches Ruby
2.6.8) and these specs began to fail.

Tagging these failures for now in advance of a fix for the ostruct
issue or some workaround in JRuby.
@headius headius added this to the JRuby milestone Sep 15, 2021
Copy link
Member Author

headius commented Sep 15, 2021

Ok, there's yet another out of sync gem here. The failing test is due to CRuby shipping a custom ostruct that does not match the 0.1.0 release they say it is.


The released 0.1.0 gem, which is what 2.6.8 claims to ship, does
not have the changes in this test. This is due to CRuby having
made custom changes to their local copy of ostruct in the CRuby
repository, and not releasing that custom version.


We will exclude this test for now.
@headius headius merged commit e2b3533 into jruby:master Sep 16, 2021
@headius headius deleted the ostruct_mess branch September 16, 2021 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant