Do not deduplicate strings with ivars #6899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is different in Ruby 3.0, which appears to deduplicate and return a new string always. The 3.0 behavior will need to be preserved in JRuby 9.4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRuby 2.7 and earlier return the same string, frozen, when the string has instance variables. This differs from JRuby 9.3 and Ruby 3.0 behavior, which always returns the interned string, possibly losing the original instance variables or metaclass.
The 3.0 behavior will need to be restored for JRuby 9.4.
This appears to fix the issues demonstrated in #6895.