StringScanner fixes and cleanup #7076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed_anchor logic * String matching The Region regs should now never be null, and modified in place when the regex match does not produce a new Region object. This is for ease of maintenance comparing to the C code, which does not track regs and beg/end separately.
Mostly filling out the missing bits of fixed_anchor logic. All tests and specs pass now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes all tests and specs and cleans up the code a bit to better match our modern patterns.
This is in prep for ruby/strscan#25 which will absorb this implementation as part of the gem.