Don't rely on FileStat#isIdentical on Windows, since it does not work [JRUBY-5726] #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… [JRUBY-5725] FileStat#isIndentical uses inodes for identity, but Windows doesn't support inodes, and always returns zero, making all files appear identical.
eregon
added a commit
that referenced
this pull request
Jun 2, 2015
ac1063b Add spec for break in a block executed inside a while. 458e964 JRuby now supports Socket.[socket]pair. a87ce01 Remove implementation and version specific Hash#compare_by_identity specs that are already tested elsewhere. 418eedf Fix wording and only specify the behavior when it was actually defined for Hash#reject. 0c28bab Add spec for Array#flatten coersion protocols. d7fd4fe BigDecimal basic operations improvements, comparisons, to_s d20e2ef More zsuper specs. 37b925e New specs for zsuper with rest arguments. e52ffab New specs for zsuper with optional arguments. a63f86e Specs for Digest.bubblebabble. 594b1b0 Fix title for Module#remove_method arguments spec. f486f6b Actually call a not defined method in method_missing spec. 4bc9586 Merge pull request #71 from JuanitoFatas/regexp/character-properties 745b346 Fix syntax on Regexp character classes spec. 6d10977 [RegExp] Add specs for Han, Hiragana, Katakana, Hangul character properties e0769b6 Move the platform guard inside the shared describe. abd2fe3 Allow failure for OSX ruby-head until it is fixed. 6443f12 Filesystem encoding is fixed on Windows and Darwin dcc1f6a Acknowledge a bug which will be fixed in 2.2.3. e5272ff Allow all orders for instance variables in marshaled Time. 8a31ccd Revert "Fix Marshal spec of Time depending on zone encoding fo recent 2.2." ec87bc5 Cleanup the .gitignore. 07a7665 Revert "Merge branch 'update-osx'" de076a2 Merge branch 'update-osx' 1d34c37 Revert "Try to be more precise in the Ruby 2.2 version for OS X." 0149116 Merge branch 'master' into update-osx b6188ca Try to be more precise in the Ruby 2.2 version for OS X. 82b3c0a use latest osx image 2fc96f5 Dir.glob results are now always in the encoding of the pattern 904793f Add OS X on Travis. a994187 Merge pull request #69 from benlovell/resolve-utf8-issues 5cb8912 Fixes misnamed UTF_8 constant a1603be Extract the way to find an available port in socket specs. dd8ad27 Unify style of {before,after} :{all,each}. ecac528 Refactor Dir[] and Dir.glob specs. 59cd27d Fix typo. 5d0495b Fix Dir.glob and Dir[] encoding specs. 72e4b19 Enable default Travis CI notifications. 0a9bcbd Replace the last instances of raise_exception by raise_error. 68d4b03 Remove usage of stasy. faf8c80 Remove deprecated STR2CSTR and rb_str2cstr CAPI specs. 4ecf19c Remove deprecated RSTRING() CAPI specs. 9079acb Remove deprecated RFLOAT() CAPI specs. 7f7ef81 Remove deprecated RARRAY() macro specs. 06b367f Cleanup CAPI specs assuming Ruby >= 2.0. c503e0f rb_hash_size is available only in MRI 2.2. b9418f6 Enable rb_set_errinfo specs. 831e525 Remove most occurences of 1.9 in the comments. fe74e42 Remove the encoding_transition feature. 239e74a Fix Math.atanh specs. 6f48a2a rb_enc_associate_index on a Symbol differs in 2.1. 6294fbc MRI 2.1 has rb_hash_size. 738ebd4 Remove most 1.8-related comments. 9abbb8a Add spec for ARGF.close with STDIN. 8fcf35b Remove 1.8.7-only conditional. 7fdaf96 Remove guard hack for Process.daemon, just use tags instead. dfdd7f3 Merge and share specs for Time, Date and DateTime #strftime. c353515 Added missing terminating newlines 5268769 Merge pull request #65 from benlovell/specify-implicit-procs f2a354e Prefer `#call` over `#()` 6cfc6fb Merge pull request #66 from ruby/remove-net-telnet 59ac739 removed net-telnet specs b4c0863 Minor fixes to the README ba948d0 Link to CONTRIBUTING.md 416556d Create CONTRIBUTING.md 14a5a01 This is now the canonical RubySpec. 8480f73 Fix README quotes and add another way to use MSpec 4fd4d6d Simplify the README instructions to run RubySpec c1e6a7f Merge pull request #64 from pxlpnk/patch-1 4554dad Specifies creation of a `lambda` 1657856 Update GitHub urls in README 09253a8 Update README. 0fbfb15 Only use :: for constant resolution and call class methods with a dot. ea69464 Do not try to load prime twice. 80119c3 Improve precision of a Prime#each assertion. 94ceed8 Remove duplicated specs for Prime. 543fc33 Merge pull request #63 from Nullset14/master d8899ff remove new_spec.rb. remove Prime.instance.each reference 3e0181e Guard 2.1-only syntax with an eval. 39a6aa4 change to Prime.instance.each instead of Prime.each 8c523ffd remove Prime.new tests 6cb1984 change Prime.instance.each to Prime.instance c994e6f remove support for obsolete Prime.new git-subtree-dir: spec/ruby git-subtree-split: ac1063b9ff5ac8514c174fe68e2ae1d7f155ae35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't rely on FileStat#isIdentical on Windows, since it does not work [JRUBY-5726]
FileStat#isIndentical uses inodes for identity, but Windows doesn't
support inodes, and always returns zero, making all files appear identical.
The commit message has the incorrect jira # (5725 instead of 5726)