New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ruby 3.2 attached_object #7638
Conversation
@headius mind taking a look at this PR? Thanks |
@edipofederle Looks good to me! Does this test come from the CRuby repository? If so, perhaps I should just update the tests and we can start checking them off the list. |
Yes, from CRuby repository. |
You can remove that test from this PR. I will sync up the Ruby 3.2 tests on the 3.2 branch. |
I updated the tests but due to a SyntaxError they do not load (test/mri/ruby/test_pattern_matching.rb fails to parse in JRuby but parses in Ruby 3.1, cc @enebo). You can run the test files directly using: |
9aa4ed9
to
9ec5bdb
Compare
done |
#7657 will fix the duplicated key error (this will still need to get merged to ruby-2.3 once it is merged. |
@edipofederle done. |
Thank you! |
Feature: https://bugs.ruby-lang.org/issues/12084
Reference: #7517