Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ruby 3.2 attached_object #7638

Merged
merged 1 commit into from Feb 15, 2023

Conversation

edipofederle
Copy link
Contributor

@edipofederle edipofederle commented Feb 8, 2023

@edipofederle edipofederle marked this pull request as ready for review February 8, 2023 16:26
@edipofederle edipofederle changed the title Add support for attached_object Add support for Ruby 3.2 attached_object Feb 8, 2023
@edipofederle
Copy link
Contributor Author

@headius mind taking a look at this PR? Thanks

@headius
Copy link
Member

headius commented Feb 10, 2023

@edipofederle Looks good to me! Does this test come from the CRuby repository? If so, perhaps I should just update the tests and we can start checking them off the list.

@edipofederle
Copy link
Contributor Author

@edipofederle Looks good to me! Does this test come from the CRuby repository? If so, perhaps I should just update the tests and we can start checking them off the list.

Yes, from CRuby repository.

@headius
Copy link
Member

headius commented Feb 12, 2023

You can remove that test from this PR. I will sync up the Ruby 3.2 tests on the 3.2 branch.

@headius
Copy link
Member

headius commented Feb 12, 2023

I updated the tests but due to a SyntaxError they do not load (test/mri/ruby/test_pattern_matching.rb fails to parse in JRuby but parses in Ruby 3.1, cc @enebo). You can run the test files directly using: jruby test/mri/runner.rb path/to/test/file.rb.

@edipofederle
Copy link
Contributor Author

You can remove that test from this PR. I will sync up the Ruby 3.2 tests on the 3.2 branch.

done

@enebo
Copy link
Member

enebo commented Feb 13, 2023

#7657 will fix the duplicated key error (this will still need to get merged to ruby-2.3 once it is merged.

@edipofederle
Copy link
Contributor Author

edipofederle commented Feb 14, 2023

#7657 will fix the duplicated key error (this will still need to get merged to ruby-2.3 once it is merged.
@enebo

Can you merge the #7658 to ruby-2.3?

@enebo
Copy link
Member

enebo commented Feb 14, 2023

@edipofederle done.

@headius headius merged commit bc942a7 into jruby:ruby-3.2 Feb 15, 2023
@headius
Copy link
Member

headius commented Feb 15, 2023

Thank you!

@headius headius added this to the JRuby 9.5.0.0 milestone Feb 15, 2023
@edipofederle edipofederle deleted the attached-object branch February 17, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants