Regression go away #7756
Merged
Regression go away #7756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regression spec was written a long time ago but did not test anything. ruby/spec does have the spec for this issue and we currently have it tagged out. Removing.
When File#absolute_path? was added it did not consider JRuby's value-added webby URIs. This has been added along with tests. Pathname was modified to not acces any possible URI as a means for absolute pathness. This broke because the old pathname code would walk back a dir at a time until it reached the root (or not). That process would somehow not pass with http:// urls. The new code uses a single regular expression and just examines the left hand side of the string. The regexp matches all URI patterns. Specs have been added to show this too. This work led to noticing that File.absolute_path itself is inconsistent with both File.absolute_path? and Pathname.absolute?. All older versions are inconsistent in the same way so I pended out the weird spec for future investigation (It is extremely unclear if someone depends on this behavior in an external gem/app).
Moved from -Ptest into jruby:spec and added not only the same tests but also added negative tests to make sure we behave like previous JRuby versions for jar resources (do not support // as root?).
Added same general logic and specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When File#absolute_path? was added it did not consider JRuby's
value-added webby URIs. This has been added along with tests.
Pathname was modified to not acces any possible URI as a means
for absolute pathness. This broke because the old pathname code
would walk back a dir at a time until it reached the root (or not).
That process would somehow not pass with http:// urls. The new code
uses a single regular expression and just examines the left hand side
of the string. The regexp matches all URI patterns. Specs have been
added to show this too.
This work led to noticing that File.absolute_path itself is inconsistent
with both File.absolute_path? and Pathname.absolute?. All older versions
are inconsistent in the same way so I pended out the weird spec for future
investigation (It is extremely unclear if someone depends on this behavior
in an external gem/app).
Additionally when roving over regression specs I noticed some glob specs
that I moved into the same spec:jruby suite along with these specs.