Java call optimizations #7789
Merged
Java call optimizations #7789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still only supports one arity with no varargs or block conversion. This code seems to have broken at some point as it used the wrong signature to check for a block argument and did exactly the wrong thing when comparing arity of a static or instance method. This implements the first part of Java method call optimization as mentioned in jrubyGH-7588.
headius
force-pushed
the
improve_java_calls
branch
from
30dd154
to
e04e0f3
Compare
|
Merging as is for 9.4.3. Additional work is details in #7588. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for optimizations for calling Java methods from Ruby.