Hide FilenoUtil warning behind native.verbose property #7970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My goal with this warning was to avoid bug reports about native
process functionality not working well when running without the
module flags we need to dig up native file descriptors from Java
channels. Since I added this, however, many things have changed:
instead uses real native IO all the way through.
descriptor.
for RubyIO objects, but most Ruby code will not need the real
fileno.
usage of JRuby, so these flags may not be helpful anyway.
I believe a warning about degraded functionality is important, but
it should be at point-of-use rather than globally just in case the
native fileno functionality might become necessary in the future.
As such, I am hiding this global warning behind the native.verbose
property, and we can consider adding other more targeted warnings
going forward.