Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ji] support java_alias with constructor #7974

Merged
merged 4 commits into from Nov 8, 2023
Merged

Conversation

kares
Copy link
Member

@kares kares commented Oct 22, 2023

the use-case, as demonstrated in the spec, is to be able to bypass constructor lookup with:

java_alias :_java_ctor_alias, :'<init>' the reasoning is similar to using java_alias with overloads


also, there's a bunch of refactoring/cleanup commits:

  • avoid constructor lookup when using setClassAllocator(Class)
  • set-up Java causes for (Java) allocator failing exceptions

@kares kares added this to the JRuby 9.4.5.0 milestone Oct 22, 2023
@kares kares marked this pull request as ready for review October 27, 2023 09:50
@headius
Copy link
Member

headius commented Oct 31, 2023

We want to push out 9.4.5.0 this week so I think this should move to 9.4.6.0 so it has time to bake on master.

@enebo enebo modified the milestones: JRuby 9.4.5.0, JRuby 9.4.6.0 Oct 31, 2023
@kares kares merged commit 353808f into jruby:master Nov 8, 2023
74 checks passed
@kares kares deleted the ji-new-instance branch November 8, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants