Full JIT support for pattern matching #8026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the following operations: * Integer, to push a native int * AsFixnum, to construct a RubyFixnum from an int * ARRAY_LENGTH runtime helper to retrieve array's length as an int * BIntInstr for branch operations against two ints To support these, the following logic was added to manage int local variables on the JVM stack: * TemporaryIntVariable: similar to the prototype unboxed variables but stored boxed in the Object[] temp array in the interpreter. The JIT knows to use int when dealing with this type of var. * int-based temps used by the pattern logic are switched to TemporaryIntVariable. A few minor utility functions are added to SkinnyMethodAdapter, including the oddly missing icmp_ge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just missing a few operations in the JIT, but I will throw some optimization work in here too.