Fix String#unpack from using capacity() and causing wrong error #8049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIT and new Prism parser were right-sizing Strings whereas the current parser will create larger than actual string length mostly. This lead to a problem where checkLimit in original unpack code would examine capacity and pass the test even though capacity is not valid data. The solution is to raise the proper error and use actual encoding limit. the original checkLimit error message is for STRTOUL in MRI in processing the number after the '@' and that was not what we were doing. I am unable to get that RangeError to occur in MRI so I am not sure when it is possible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIT and new Prism parser were right-sizing Strings whereas the current parser will create larger than actual string length mostly. This lead to a problem where checkLimit in original unpack code would examine capacity and pass the test even though capacity is not valid data.
The solution is to raise the proper error and use actual encoding limit. the original checkLimit error message is for STRTOUL in MRI in processing the number after the '@' and that was not what we were doing. I am unable to get that RangeError to occur in MRI so I am not sure when it is possible?