Update some warnings to deprecated #8071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See ruby/ruby#3917 for the same changes in CRuby. |
This also marks syscall as not implemented (warns of pending deletion in CRuby) and modifies all RubyWarnings.warning* forms to no-op on verbose, as they used to (unsure when this changed).
headius
force-pushed
the
deprecated_things
branch
from
7d2617f
to
19cded4
Compare
|
Changing warning() to only fire in verbose mode exposed several places where we call warning() instead of warn() as in CRuby. I'll fix those cases as well. |
headius
force-pushed
the
deprecated_things
branch
from
19cded4
to
ca4375f
Compare
warning at some point started to warn all the time, even when not verbose. Previous commit modified this logic to match CRuby, with warning only producing output in verbose mode, but several specs and tests failed that expected that output. These cases should be warn, as in CRuby.
headius
force-pushed
the
deprecated_things
branch
from
ca4375f
to
4d63582
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also marks syscall as not implemented (warns of pending deletion in CRuby) and modifies all RubyWarnings.warning* forms to no-op on verbose, as they used to (unsure when this changed).