Prism pluggable integration work #8103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prints out statistics on how many files and evals occurred. It also prints out total time spent while parsing and generating a syntax tree.
Using Prism through Chicory
Symbol encoding has been fixed (Allowing workaround to be removed). Some change in pattern matching showing implicit assignment (nothing changed in correctness so I am not sure if this was a semantic change).
…ngs in our codebase
…rism was acting differently...still makes me wonder how --dev worked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental development at its best.
This is a huge PR but it is impossible to do this in pieces.
For onlookers/reviewers the main problem points would be whether I appropriately support old parse methods on Ruby with the new ParserManager calls. None of those probably matter too much as it is possible only JRuby calls them. They should continue to work though.