Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] update jruby-openssl to 0.14.5 #8196

Merged
merged 2 commits into from Apr 20, 2024
Merged

Conversation

kares
Copy link
Member

@kares kares commented Apr 11, 2024

@kares kares added this to the JRuby 9.4.7.0 milestone Apr 11, 2024
@kares
Copy link
Member Author

kares commented Apr 11, 2024

🔴 there seems to be some "regressions" while running the MRI suite:

  1) Error:
OpenSSL::TestX509Request#test_public_key:
Java::JavaLang::AssertionError: could not resolve name for oid: 1.2.840.10040.4.1
    org.jruby.ext.openssl.impl.PKCS10Request.getPublicKeyAlgorithm(PKCS10Request.java:222)
    org.jruby.ext.openssl.impl.PKCS10Request.sign(PKCS10Request.java:138)
    org.jruby.ext.openssl.X509Request.sign(X509Request.java:308)
    org.jruby.ext.openssl.X509Request$INVOKER$i$2$0$sign_DBG.call(X509Request$INVOKER$i$2$0$sign_DBG.gen)
    org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:291)
    org.jruby.ir.interpreter.InterpreterEngine.processCall(InterpreterEngine.java:324)
    org.jruby.ir.interpreter.InterpreterEngine.interpret(InterpreterEngine.java:153)
    ...


  2) Error:
OpenSSL::TestX509Request#test_sign_and_verify_dsa:
Java::JavaLang::AssertionError: could not resolve name for oid: 1.2.840.10040.4.1
    org.jruby.ext.openssl.impl.PKCS10Request.getPublicKeyAlgorithm(PKCS10Request.java:222)
    org.jruby.ext.openssl.impl.PKCS10Request.sign(PKCS10Request.java:138)
    org.jruby.ext.openssl.X509Request.sign(X509Request.java:308)
    org.jruby.ext.openssl.X509Request$INVOKER$i$2$0$sign_DBG.call(X509Request$INVOKER$i$2$0$sign_DBG.gen)
    org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:291)
    org.jruby.ir.interpreter.InterpreterEngine.processCall(InterpreterEngine.java:324)
    org.jruby.ir.interpreter.InterpreterEngine.interpret(InterpreterEngine.java:153)
    ...

a new assert added in 0.14.4 fails (there's been a fix in related code, thus this is legit)

@kares kares marked this pull request as draft April 11, 2024 14:27
@kares kares changed the title [deps] update jruby-openssl to 0.14.4 [deps] update jruby-openssl to 0.14.5 Apr 20, 2024
@kares kares marked this pull request as ready for review April 20, 2024 12:54
@kares kares merged commit 4c961c3 into jruby:master Apr 20, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant