Only set up Java:: constants when accessed directly #8208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously whenever we see a new type of Java object, we both set up the proxy class AND set the constant. If that object's class is not from the typical Java integration classloader hierarchy, it will pollute the Java:: module with a normally inaccessible entry. This change only sets up the constant when it is accessed through the normal package reference, rather than when first seen. Fixes jruby#8156
headius
force-pushed
the
more_lazy_java_constant_setup
branch
from
53861ce
to
31f1ed6
Compare
In order to avoid polluting the Java:: namespace with classes from other classloader hierarchies, we are modifying the proxy class setup process to not eagerly set a constant for newly-encountered classes. This property controls the behavior, defaulting to true for JRuby 9.4.x but likely to switch to false in a future release (probably JRuby 10). The constants will still be defined if accessed directly, as before. We just won't define them when we happen to see an object with an unfamiliar type. See jruby#8208 and the bug it fixed jruby#8156.
|
This is now guarded by an option so we can ship it in 9.4.7.0. |
headius
added a commit
to headius/jruby
that referenced
this pull request
Apr 25, 2024
headius
added a commit
to headius/jruby
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously whenever we see a new type of Java object, we both set up the proxy class AND set the constant. If that object's class is not from the typical Java integration classloader hierarchy, it will pollute the Java:: module with a normally inaccessible entry.
This change only sets up the constant when it is accessed through the normal package reference, rather than when first seen.
Fixes #8156.