Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make attrs position-aware #8215

Closed
wants to merge 2 commits into from
Closed

Make attrs position-aware #8215

wants to merge 2 commits into from

Commits on Apr 25, 2024

  1. Make attrs position-aware 

    This patch adds filename and line number information to all attr
methods using our stack walker logic. It works correctly, but it
also imposes a severe performance impact on attr definition, due
to the cost of materializing the JVM stack trace for mining. Even
when using the StackWalker API on a recent JVM, this performs
more than 100x worse per attr defined.

A different solution is probably needed.
    @headius
    headius committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a3d37d9 View commit details
    Browse the repository at this point in the history

  2. Add benchmark for attr_reader

    @headius
    headius committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    56639e6 View commit details
    Browse the repository at this point in the history